Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harzbahn: MHE shows as full withholding #5150

Open
Bobsson opened this issue Apr 27, 2021 · 2 comments
Open

Harzbahn: MHE shows as full withholding #5150

Bobsson opened this issue Apr 27, 2021 · 2 comments
Labels
Harzbahn 1873 minor bug A minor bug that doesn't impact game play (erronous logging)

Comments

@Bobsson
Copy link

Bobsson commented Apr 27, 2021

In Harzbahn 1873, the MHE always pays out a dividend, automatically. However, the spreadsheet (and the company card) always show it as having done a full withholding. The log is correct, and the money paid is correct, this is simply a UI inconsistency.

image
image
image

@roseundy roseundy added minor bug A minor bug that doesn't impact game play (erronous logging) Harzbahn 1873 and removed needs triage labels May 2, 2021
@roseundy
Copy link
Collaborator

roseundy commented May 2, 2021

Unfortunately this will require a surprising amount of work to fix, touching six other games as well as some common code. It's doable, but it will have to wait.

@roseundy
Copy link
Collaborator

roseundy commented May 2, 2021

It will require updating the OperatingInfo class to pass the dividend type separately from the dividend action. The UI will need to be updated to use the new parameter and 1822, 2824, 1860, 1862, 18Mag as well as 1873 will need to be updated to provide the new parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Harzbahn 1873 minor bug A minor bug that doesn't impact game play (erronous logging)
Projects
None yet
Development

No branches or pull requests

2 participants