Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Remove train_actions_always_use_operating_round_view #7169

Open
ventusignis opened this issue Feb 15, 2022 · 0 comments
Open

Refactor: Remove train_actions_always_use_operating_round_view #7169

ventusignis opened this issue Feb 15, 2022 · 0 comments
Labels

Comments

@ventusignis
Copy link
Collaborator

In assets/app/view/game_page.rb there is a somewhat hacky conditional for 1840 that can be cleaned up to be cleaner. This is currently known to affect 1840 and 18USA.

oh crap :D
in 1840 the merger round is the "buy tram lines". There is a "real" buy and a scrap train step in it.

I am not sure how to resolve that other than chris suggested. I need a real view and chris does not need a real view, just the action.
Maybe the name could be clearer, or we could add a "show_action_view?" to the step. This would put the logic more into the steps and away from the game.

Did that somehow help? ;)

Originally posted by @Zwergenpunk in #7099 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants