Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a bug or not a bug #108

Open
dclovec opened this issue Apr 25, 2016 · 5 comments
Open

a bug or not a bug #108

dclovec opened this issue Apr 25, 2016 · 5 comments

Comments

@dclovec
Copy link

dclovec commented Apr 25, 2016

My project is: will not scroll, the

element in can scroll, but echo not worked on in the
. Maybe echo just only listen the 's scroll event ? If yes, can you fix this for using on any element not just ? It can add a pramameter named "container", then listen scroll event of the "container". Thank you!

@toddmotto
Copy link
Owner

You could change the script slightly to allow you to pass a custom selector to Echo. I don't think it'd be a huge change to add this functionality into the code, would you be able to submit a PR?

@dclovec
Copy link
Author

dclovec commented Apr 26, 2016

OK.

@dclovec
Copy link
Author

dclovec commented Apr 26, 2016

I can't push the source code, permission denied. @toddmotto

@toddmotto
Copy link
Owner

Did you fork the project? :) you'll need to fork, commit to your own repo, then pull request your branch across to mine :)

@dclovec
Copy link
Author

dclovec commented May 4, 2016

I pulled it, checkout!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants