fix(electron): respect locale for spellchecker #8844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
graphite-app
bot
requested review from
forehalo,
EYHN,
CatsJuice and
JimmFly
pengx17
force-pushed
the
xp/11-15-fix_electron_respect_locale_for_spellchecker
branch
from
24e5ec9 to
57ccd48
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4724324. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
forehalo
reviewed
Nov 20, 2024
forehalo
approved these changes
Nov 20, 2024
pengx17
force-pushed
the
xp/11-15-fix_electron_respect_locale_for_spellchecker
branch
from
57ccd48 to
6d89b11
Compare
Merge activity
|
pengx17
added a commit
that referenced
this pull request
Nov 20, 2024
may fix #8837. fix AF-1712 MacOS automatically do spellcheck based on given text. This only works for Win/Linux. 
pengx17
force-pushed
the
xp/11-15-fix_electron_respect_locale_for_spellchecker
branch
from
6d89b11 to
47954da
Compare
may fix #8837. fix AF-1712 MacOS automatically do spellcheck based on given text. This only works for Win/Linux. 
pengx17
force-pushed
the
xp/11-15-fix_electron_respect_locale_for_spellchecker
branch
from
47954da to
4724324
Compare
graphite-app
bot
deleted the
xp/11-15-fix_electron_respect_locale_for_spellchecker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
may fix #8837.
fix AF-1712
MacOS automatically do spellcheck based on given text. This only works for Win/Linux.
