Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): pdf preview #8569

Merged
merged 6 commits into from
Nov 12, 2024
Merged

feat(core): pdf preview #8569

merged 6 commits into from
Nov 12, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Oct 21, 2024

What's Changed!

  • adds Attachment Viewer Compenent, includes PDF Viewer Component
  • adds attachment page route
🎥 Video uploaded on Graphite:

Copy link

graphite-app bot commented Oct 21, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fundon commented Oct 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Oct 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c5bf03d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@fundon fundon marked this pull request as ready for review October 21, 2024 12:47
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.19%. Comparing base (68573aa) to head (c5bf03d).
Report is 3 commits behind head on canary.

Files with missing lines Patch % Lines
packages/common/infra/src/op/message.ts 37.50% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8569      +/-   ##
==========================================
- Coverage   70.20%   70.19%   -0.01%     
==========================================
  Files         549      549              
  Lines       33893    33900       +7     
  Branches     3043     3044       +1     
==========================================
+ Hits        23795    23797       +2     
- Misses       9728     9732       +4     
- Partials      370      371       +1     
Flag Coverage Δ
server-test 77.12% <ø> (ø)
unittest 45.88% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/10_21_feat_pdf_preview branch from fe85fc3 to 0003858 Compare October 22, 2024 03:24
@fundon fundon force-pushed the fundon/10_21_feat_pdf_preview branch from 0003858 to 95aee9e Compare October 22, 2024 07:17
@fundon fundon force-pushed the fundon/10_21_feat_pdf_preview branch from 95aee9e to 5cfaa82 Compare October 22, 2024 09:06
@fundon fundon changed the base branch from canary to 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller October 22, 2024 09:06
@pengx17 pengx17 force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from f8f786b to 03cb2c8 Compare October 22, 2024 10:30
@fundon fundon force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from 03cb2c8 to a459499 Compare October 22, 2024 23:55
@fundon fundon force-pushed the fundon/10_21_feat_pdf_preview branch from 5cfaa82 to dbd1cd7 Compare October 22, 2024 23:55
@fundon fundon force-pushed the fundon/10_21_feat_pdf_preview branch from dbd1cd7 to 41d99e1 Compare October 23, 2024 12:38
@pengx17 pengx17 force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from a459499 to 879aac4 Compare October 25, 2024 04:43
@forehalo forehalo merged commit f4abe39 into canary Nov 12, 2024
46 checks passed
@forehalo forehalo deleted the fundon/10_21_feat_pdf_preview branch November 12, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app docs Improvements or additions to documentation mod:component mod:dev mod:env mod:i18n Related to i18n mod:infra Environment related issues and discussions test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants