feat: pdf embed view component #8671
Open
+732
−249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3a018ce. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #8671 +/- ##
==========================================
- Coverage 70.30% 70.26% -0.05%
==========================================
Files 550 551 +1
Lines 33980 34008 +28
Branches 3052 3060 +8
==========================================
+ Hits 23889 23895 +6
- Misses 9719 9740 +21
- Partials 372 373 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
90f0665
to
facb69a
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/frontend/core/src/components/attachment-viewer/embed/index.tsx
Outdated
Show resolved
Hide resolved
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
facb69a
to
c53d8cf
Compare
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
c53d8cf
to
0bed2a8
Compare
fundon
force-pushed
the
fundon/10_21_feat_pdf_preview
branch
from
c7ca99b
to
7910f20
Compare
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
0bed2a8
to
9cdb92e
Compare
fundon
force-pushed
the
fundon/10_21_feat_pdf_preview
branch
from
7910f20
to
25086b9
Compare
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
9cdb92e
to
14a1b25
Compare
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
14a1b25
to
e74620c
Compare
fundon
force-pushed
the
fundon/10_21_feat_pdf_preview
branch
3 times, most recently
from
07676e2
to
c5bf03d
Compare
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
1e59de5
to
e992fe9
Compare
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
e992fe9
to
c55a81c
Compare
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
c55a81c
to
e62030d
Compare
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
e62030d
to
dc4fa3d
Compare
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
dc4fa3d
to
e4393af
Compare
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
e4393af
to
bb080dd
Compare
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
bb080dd
to
befe0a8
Compare
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
befe0a8
to
3a018ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: AF-1445
Upstreams: toeverything/blocksuite#8658, toeverything/blocksuite#8752
What's Changed
IntersectionObserverto determine lazy loadingPDFViewerEmbeddedcomponent