-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mobile): disable swipe back gesture when there is no back in header #8876
base: canary
Are you sure you want to change the base?
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8443371. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
this.disable().catch(console.error); | ||
} | ||
|
||
setEnabled(enabled: boolean) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use effect()
?
Can ensure the order of asynchronous calls.
setEnabled = effect(
distinctUntilChanged(),
exhaustMapWithTrailing((enable: boolean) => {
return fromPromise(async () => {
if (!this.navigationGestureProvider) {
return;
}
if (enable) {
await this.navigationGestureProvider.enable();
} else {
await this.navigationGestureProvider.disable();
}
return;
}).pipe(
mergeMap(() => EMPTY),
catchError(err => {
logger.error('navigationGestureProvider error', err);
return EMPTY;
})
);
})
);
23e31d5
to
454363d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #8876 +/- ##
==========================================
- Coverage 70.89% 70.24% -0.66%
==========================================
Files 550 551 +1
Lines 34005 34014 +9
Branches 3095 3053 -42
==========================================
- Hits 24109 23892 -217
- Misses 9545 9750 +205
- Partials 351 372 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
454363d
to
b3200bd
Compare
b3200bd
to
387a90a
Compare
387a90a
to
8443371
Compare
close AF-1663, AF-1756