Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): disable swipe back gesture when there is no back in header #8876

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Nov 20, 2024

close AF-1663, AF-1756

Copy link

graphite-app bot commented Nov 20, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Nov 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8443371. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@CatsJuice CatsJuice marked this pull request as ready for review November 21, 2024 02:11
this.disable().catch(console.error);
}

setEnabled(enabled: boolean) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use effect() ?

Can ensure the order of asynchronous calls.

setEnabled = effect(
    distinctUntilChanged(),
    exhaustMapWithTrailing((enable: boolean) => {
      return fromPromise(async () => {
        if (!this.navigationGestureProvider) {
          return;
        }
        if (enable) {
          await this.navigationGestureProvider.enable();
        } else {
          await this.navigationGestureProvider.disable();
        }
        return;
      }).pipe(
        mergeMap(() => EMPTY),
        catchError(err => {
          logger.error('navigationGestureProvider error', err);
          return EMPTY;
        })
      );
    })
  );

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.24%. Comparing base (ad10690) to head (8443371).

Files with missing lines Patch % Lines
packages/frontend/component/src/ui/modal/modal.tsx 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8876      +/-   ##
==========================================
- Coverage   70.89%   70.24%   -0.66%     
==========================================
  Files         550      551       +1     
  Lines       34005    34014       +9     
  Branches     3095     3053      -42     
==========================================
- Hits        24109    23892     -217     
- Misses       9545     9750     +205     
- Partials      351      372      +21     
Flag Coverage Δ
server-test 77.14% <ø> (-0.70%) ⬇️
unittest 46.06% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants