Update windows-sys. #1820
Closed
Update windows-sys. #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should probably coordinate with Tokio on this. /cc @Darksonn |
|
Yes. I don't think we need to force people to only use Tokio/mio combinations with the same windows-sys, but we should also update it in Tokio. |
|
@westy92 are you running the tests locally? Or only using the CI for testing? |
|
@Thomasdezeeuw tests are passing on my Mac, but I am unable to test on Windows. |
|
Since this is failing the CI and no progress has been made to fix it I'm going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: https://github.com/microsoft/windows-rs/releases/tag/0.59.0