Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying songs in playlist creation URL #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Feb 7, 2013

Example usage:

tomahawk 'tomahawk://playlist/new/?title=Awesome&track_0_artist=Bloc+Party&track_0_title=Flux&track_1_artist=Vampire+Weekend&track_1_title=A+Punk'

@muesli
Copy link
Member

muesli commented Mar 23, 2013

I think generally I'm fine with this. I'm just wondering if it wouldn't be more elegant to pass in artists & tracks in json as one encoded url parameter. Thoughts, anyone?

@xhochy
Copy link
Member Author

xhochy commented Mar 23, 2013

It's a question of command line length. Considering that there's sometimes a limit of 64k characters even the above format maybe a bit too large. For example base64 encoded JSON would be even larger, which would drop support for larger playlists.

@dschmidt
Copy link
Member

Tbh I don't like that scheme too much, I'd rather see something like:

tomahawk://playlist/new/?title=Awesome&track[0][artist]=Bloc+Party&track[0][title]=Flux

see: http://stackoverflow.com/questions/7206978/how-to-pass-an-array-via-get-in-php

or even shorter: title[0]=Flux&artist[0]=Bloc+Party

@dschmidt
Copy link
Member

Accoring to @xhochy this https://bugs.tomahawk-player.org/browse/TWK-1268 makes it unusable currently, needs to be fixed before this can/should be merged...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants