-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newlogo #909
base: main
Are you sure you want to change the base?
Newlogo #909
Conversation
We have been discussing these new logos for a long time. Can we get a blessing to make them a part of the TOML project? @pradyunsg @mojombo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @1984logo you intended to say "config files for humans" with an "s"?
EDIT: Ignore this one. But look at the next one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just to correct a misspelling.
Co-authored-by: Dave Ostroske <[email protected]>
for more information, see https://pre-commit.ci
Adding only the original vector files should be more than sufficient. Everyone should be able to convert it to the size they need and it prevents committing binary files to a repo (and also ensure there is a single source of truth). |
|
||
The tagline "config files for humans" is intended to be use in conjuction with | ||
the logo on headers, footers, or any other place where the logo can be displayed | ||
in large format (to preserve the lisibility of the tagline). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo?
Also some of these icons like logos/monochrome/toml-mark-black-L.png seem to have an improper viewbox showing padding on some sides but not the others. |
Having raster versions of the logo in the repository is a common practice. It helps the quick adoption of the logo in most use cases.
You're right. Thank you for noticing. Let me fix that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some typos:
|
||
The color versions are intended for a white background, while the reverse | ||
versions are intended for a black background. The fallback versions were | ||
designed for when the background cannot be controlled, such as in Github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
designed for when the background cannot be controlled, such as in Github | |
designed for when the background cannot be controlled, such as in GitHub |
The color versions are intended for a white background, while the reverse | ||
versions are intended for a black background. The fallback versions were | ||
designed for when the background cannot be controlled, such as in Github | ||
`readme.md` files where the background depends on the user's dark or light theme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`readme.md` files where the background depends on the user's dark or light theme | |
`README.md` files where the background depends on the user's dark or light theme |
|
||
## Icons | ||
|
||
The icons are indented to be used as favicon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icons are indented to be used as favicon. | |
The icons are intended to be used as favicons. |
|
||
## Tagline | ||
|
||
The tagline "config files for humans" is intended to be use in conjuction with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tagline "config files for humans" is intended to be use in conjuction with | |
The tagline "config files for humans" is intended to be used in conjuction with |
|
||
The tagline "config files for humans" is intended to be use in conjuction with | ||
the logo on headers, footers, or any other place where the logo can be displayed | ||
in large format (to preserve the lisibility of the tagline). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in large format (to preserve the lisibility of the tagline). | |
in large format (to preserve the visibility of the tagline). |
I put the new TOML logos, marks and icons in this PR. Let me know if it works for you.