Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding pre-commit #34

Open
eugenedavis-tomtom opened this issue Jun 15, 2022 · 0 comments
Open

Adding pre-commit #34

eugenedavis-tomtom opened this issue Jun 15, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@eugenedavis-tomtom
Copy link
Contributor

To save time and computation power, it would be good to add at least the short-running PR checks to a pre-commit hook.

It could run:

  • black --check
  • pylint
  • mypy
  • pytest (this could be reduce to a subset of tests if pytest test-time increases)
  • hadolint Dockerfile lint
  • bandit
  • version check

Docker builds and security scans should probably be skipped.
@eugenedavis-tomtom eugenedavis-tomtom added enhancement New feature or request good first issue Good for newcomers labels Jun 15, 2022
NevenVucinic-TomTom pushed a commit that referenced this issue Nov 24, 2022
@eugene-davis
Handle empty metadata (#43)
9e28a1c 
* Set static UID and GID (#34)

* Set static UID and GID

* Bump version: 1.1.13 → 1.1.14

* Check if metadata dict is empty

* Bump version: 1.1.14 → 1.1.15

* Bump version: 1.1.14 → 1.1.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eugenedavis-tomtom