Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI-REACT: Wrong modal in mobile #156

Closed
abolfazlakbarzadeh opened this issue Apr 25, 2024 · 2 comments · May be fixed by #157
Closed

UI-REACT: Wrong modal in mobile #156

abolfazlakbarzadeh opened this issue Apr 25, 2024 · 2 comments · May be fixed by #157
Assignees
Labels
bug Something isn't working

Comments

@abolfazlakbarzadeh
Copy link

Describe the bug

not working correctly on a variety of mobile screens, some mobile screens are wider than 440px so the modal shows a QR Code to scan instead of displaying wallets to select and navigate into the related app

Expected behavior

on any mobile device should show a modal to select wallet and then navigate to the app to confirm connection or payment

Current behavior

some mobile screens are wider than 440px so the modal shows a QR Code to scan instead of displaying wallets to select and navigate into the related app

Steps to Reproduce

1- use a mobile for example POCO x3 pro, this model's screen width is ~490px
2- open up the webpage that contains the connect or pay button and click on it.
3- so you see a modal that shows a QR Code to scan

Environment

└─┬ @tonconnect/[email protected]
└─┬ @tonconnect/[email protected]
└─┬ @tonconnect/[email protected]
├── @tonconnect/[email protected]
├── @tonconnect/[email protected]
└── @tonconnect/[email protected]

  Android 10
  Chrome

Additional context

No response

@abolfazlakbarzadeh abolfazlakbarzadeh added the bug Something isn't working label Apr 25, 2024
@abolfazlakbarzadeh abolfazlakbarzadeh changed the title [<SDK or UI or UI-REACT or PROTOCOL>]: <description> UI-REACT: Wrong modal in mobile Apr 25, 2024
@thekiba
Copy link
Contributor

thekiba commented Apr 27, 2024

Please upgrade to @tonconnect/[email protected] to fix this issue.

Let me know if the problem persists.

@abolfazlakbarzadeh
Copy link
Author

the current version of the installed package is already 2.0.2, I had to fix this by myself and fix another bug related to redirecting to the wallet in IOS OS, I just made a pull request for that #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants