Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially value range restriction in home assistant auto discovery #277

Open
mraction opened this issue Dec 23, 2024 · 1 comment
Open

Comments

@mraction
Copy link

In commit f095ee7 is a new range check added, that allows only values, between INT32_MIN and INT32_MAX for min/max values in the home assistant auto discovery message.

The problem is, that in https://github.com/toniebox-reverse-engineering/teddycloud/blob/master/src/settings.c are also bigger ranges are defined (for example UINT64_MAX).

Currently that is not a problem, because all these settings are internal and not publishes via mqtt, but for the future it could be a problem, because this restriction is not really visible to the developer while adding new settings.

@mraction
Copy link
Author

@g3gg0 I think you might be interested in this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant