Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tonies details page #102

Open
henryk86 opened this issue Aug 19, 2024 · 7 comments
Open

Tonies details page #102

henryk86 opened this issue Aug 19, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@henryk86
Copy link
Collaborator

henryk86 commented Aug 19, 2024

Add a tonies/tag details page

  • image on card links to that page
  • show model infos (image, tracks if source info is empty/not available)
  • Show source infos (image, tracks)
  • Edit Dialogs like in cards view

Pros and cons:
Pros:

  • store direct link to certain tonies for easy source changing (save page as favorite)
  • Space for future features like more stats (last played, how often played, how often source changed,…)
  • Feature exists on boxine

Cons:

  • currently no more informations as on cards view
  • Back link / history go back might break current cards filter, need for storing set filter
@henryk86 henryk86 added the enhancement New feature or request label Oct 8, 2024
@dgenzer
Copy link
Contributor

dgenzer commented Jan 21, 2025

I'm currently working on the detail page.
When you click on an image in the Tonie list, you're redirected to the detail page. Is there any important information missing, or is it perhaps too much?

see dgenzer@dc1917a

Screenshots

Desktop:
Image

Mobile / iOS
Image

@henryk86
Copy link
Collaborator Author

henryk86 commented Jan 22, 2025

Hi thanks for your efforts, but it’s always good to speak about things before do something.

The intense of the details page was to show more details not to show all possible dialogs. Those details are not yet available as there is no additional way to store some things.

For now the details page would only contain the same infos as a overview card does + the infos from the information modal.

That’s why I did not start the implementation yet as there is no real gain of having such page.

It makes no sense to show all dialogs all the time.

You are duplicating a lot of things. If there is any thing to be changed, you have to do it twice.

All Edit dialogs should still be dialogs which opens on a click (like it is on the cards overview page) They do not need to be open all the time. The dialogs should be moved to a common component if used twice.

Live and cloud is duplicated as info ( even if one is able change it)

@dgenzer
Copy link
Contributor

dgenzer commented Jan 22, 2025

Hey, thanks for the reply.

I created the page as a way to dive deeper into the project and interact with it more. :)

I removed "nocloud" and "live" from the overview and added an edit mode.

My current roadmap is:

  • handle duplicate code (e.g. extend/refactor the edit modal and the file browser)
  • save the filters when coming from ToniesList
  • add links to breadcrumbs (especially for the "series"-part I added)

Some additional ideas:

Do you have any other suggestions?

@henryk86
Copy link
Collaborator Author

Currently I see a lot of blockers as there are dependencies to the backend (missing functionality) and other things (tonies.json).

Feel free to open new issues for those ideas.

If you add new features, please also add them in the changelog page.

@henryk86
Copy link
Collaborator Author

@SciLor might you add @dgenzer to the developer telegram group for better alignment on new features?

@henryk86
Copy link
Collaborator Author

henryk86 commented Feb 1, 2025

@dgenzer do you have a telegram account?

@dgenzer
Copy link
Contributor

dgenzer commented Feb 1, 2025

@dgenzer do you have a telegram account?

Yes, it's the same username as here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants