Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-v should be passed to WSL when it is passed on host #521

Closed
RuiNtD opened this issue Jul 26, 2023 · 5 comments · Fixed by #556
Closed

-v should be passed to WSL when it is passed on host #521

RuiNtD opened this issue Jul 26, 2023 · 5 comments · Fixed by #556
Labels
C-feature request New feature request

Comments

@RuiNtD
Copy link

RuiNtD commented Jul 26, 2023

I want to suggest some general feature

Topgrade should pass -v / --verbose to the WSL step when it's passed to the main topgrade command.

@SteveLauC
Copy link
Member

Rationale for this change?

@RuiNtD
Copy link
Author

RuiNtD commented Jul 27, 2023

Sorry, let me rephrase: -v should be passed to WSL when -v is passed to the main command.

When using -v on Windows, it stops being Verbose during the WSL step.

@SteveLauC
Copy link
Member

Get it, this will be a nice improvement!

@SteveLauC SteveLauC added the C-feature request New feature request label Jul 27, 2023
@SteveLauC SteveLauC changed the title -v should be passed from Windows to WSL -v should be passed to WSL when it is passed on host Jul 27, 2023
ssmendon added a commit to ssmendon/topgrade that referenced this issue Sep 21, 2023
ssmendon added a commit to ssmendon/topgrade that referenced this issue Sep 22, 2023
@ssmendon
Copy link
Contributor

ssmendon commented Sep 23, 2023

I submitted #556 for this, by the way. I tested it out on Windows, and it seemed to give me the expected result.

I'd appreciate any extra testing for it though.

PS. Could someone test the -y option, whether that's passed to WSL? It didn't look like it's passed to the topgrade executable in WSL based on what I first tried when adding the -v flag.

@RuiNtD

@SteveLauC
Copy link
Member

I submitted #556 for this, by the way. I tested it out on Windows, and it seemed to give me the expected result.

Thanks for working on it!

Could someone test the -y option, whether that's passed to WSL? It didn't look like it's passed to the topgrade executable in WSL based on what I first tried when adding the -v flag.

The verbose argument would be useful for debugging, say a user is having issues with WSL, it can paste the output of topgrade -v from its host without having to execute it inside of the WSL.

For the assume_yes (-y) option, I haven't seen much value in it, users can configure this option in the configuration file if they want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature request New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants