Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One problem with gmodule.lua #137

Open
zhangty12 opened this issue Dec 17, 2016 · 0 comments
Open

One problem with gmodule.lua #137

zhangty12 opened this issue Dec 17, 2016 · 0 comments

Comments

@zhangty12
Copy link

On gmodule.lua : line-337, the reassignment " input = input[1] " seems problematic.

Say, if the module associated with the node is a JoinTable(1), and the input is a singleton {torch.randn(5, 5)}, the program may crash as gmodule would send a tensor torch.randn(5, 5) directly to JoinTable(1):forward(***), instead of a table {torch.randn(5, 5)}.

Therefore, when wrapped up in a gmodule, JoinTable():forward(**) cannot accept singletons as their inputs, and so this contradicts JoinTable's original functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant