BLD: prefer to use bdist_wheel from setuptools rather than wheel #3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to upcoming changes to setuptools (pypa/setuptools#4647) using bdist_wheel from wheel will fail.
|
I'm also unsure of my policy for setuptools versions; I've never really had to think about it. Now that we can put a version in the build-system section of pyproject.toml there's no real reason to support older versions of setuptools, is there? I'd love to get rid of this whole bdist_wheel override, and it looks like it might be possible with current versions of setuptools. I haven't tested this PR (on the repo that I copied the bdist_wheel override from), but it looks like setuptools now has better understanding of abi3. https://github.com/joerick/python-abi3-package-sample/pull/30/files |
bdarnell
added a commit
to bdarnell/tornado
that referenced
this pull request
Oct 24, 2024
This is no longer necessary in recent versions of setuptools (and we now check that abi3 is used properly in official releases). The bdist_wheel implementation is being moved from the wheel package into setuptools so overriding it will stop working in the future. Follows the example of joerick/python-abi3-package-sample#30 Replaces tornadoweb#3425
|
In #3433 I've removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to upcoming changes to
setuptools (pypa/setuptools#4647) using bdist_wheel from wheel will fail.
This could possibly be simplified to always use
wheelfrom setuptools, however I am unsure on your policy on the range of setuptool versions supported.