From 64a08ce3ceae323388a22b3eac33eeb98e1d2f56 Mon Sep 17 00:00:00 2001 From: Oren Farhi Date: Wed, 28 Feb 2018 10:27:55 +0200 Subject: [PATCH 1/2] add(github): templates for issue and pr --- .github/ISSUE_TEMPLATE.md | 32 +++++++++++++++++++++++++++++++- .github/PULL_REQUEST_TEMPLATE.md | 29 +++++++++++++++++++++++++++++ 2 files changed, 60 insertions(+), 1 deletion(-) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index c3e88e3c..15007dbe 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,2 +1,32 @@ \ No newline at end of file +👉 https://opencollective.com/ngx-infinite-scroll/donate --> +Your issue may already be reported! +Please search on the [issue track](../) before creating one. + +## Expected Behavior + + + + +## Actual Behavior + + + +## Possible Solution + + + +### Steps To Reproduce / Demo (if applicable) +[ ] Please share a [stackblitz](https://stackblitz.com/) or [plunkr](https://plnkr.co/) demo reproducing this issue + + +### Context + + + +### Your Environment + +[ ] Version used: +[ ] Browser Name and version: +[ ] (Optional) Operating System and version (desktop or mobile): +[ ] (Optional) Link to your project: \ No newline at end of file diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..3bcece70 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,29 @@ +A similar PR may already be submitted! +Please search among the [Pull request](../) before creating one. + +Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. + +**Summary** + + + +This PR fixes/implements the following **bugs/features** + +* [ ] #issue1 +* [ ] #issue2 +* [ ] #Feature1 +* [ ] #Feature2 +* [ ] Breaking changes + + + +Explain the **motivation** for making this change. What existing problem does the pull request solve? + + + +### Requirements +Make sure these boxes are checked: +- [ ] link to an issue +- [ ] tests are updated (added/changed/removed) +- [ ] tests run successfully (local) +- [ ] tests run successfully (TravisCI) \ No newline at end of file From 314a5ba9832c77c46ae38426a597cce6b99f6fa0 Mon Sep 17 00:00:00 2001 From: Oren Farhi Date: Wed, 28 Feb 2018 10:32:33 +0200 Subject: [PATCH 2/2] chore(pr-template): add styleguide link for subject formatting --- .github/PULL_REQUEST_TEMPLATE.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 3bcece70..1d181863 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -26,4 +26,5 @@ Make sure these boxes are checked: - [ ] link to an issue - [ ] tests are updated (added/changed/removed) - [ ] tests run successfully (local) -- [ ] tests run successfully (TravisCI) \ No newline at end of file +- [ ] tests run successfully (TravisCI) +- [ ] please follow this [styleguide](https://gist.github.com/stephenparish/9941e89d80e2bc58a153#subject-line) for this pr title \ No newline at end of file