Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maxBy: difference with lodash #948

Open
rejetto opened this issue Feb 1, 2025 · 1 comment
Open

maxBy: difference with lodash #948

rejetto opened this issue Feb 1, 2025 · 1 comment

Comments

@rejetto
Copy link

rejetto commented Feb 1, 2025 •
edited
Loading

hi, lodash's maxBy supports string as second argument (then converted to x => x?.[string], of course) but maxBy in 'es-toolkit/compat' doesn't
@gs18004 gs18004 mentioned this issue Feb 2, 2025
Open
@gs18004
Copy link

gs18004 commented Feb 2, 2025 •
edited
Loading

I made a PR on #949.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rejetto @gs18004