feat(isElement): Implement isElement
#839
Merged
+141
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
filipsobol
commented
Nov 23, 2024
Comment on lines
+13
to
+19
| /* | ||
| it( 'should return `true` for elements', () => { | ||
| if ( document ) { | ||
| expect( isElement( body ) ).toBe( true ); | ||
| } | ||
| } ); | ||
| */ |
There was a problem hiding this comment.
Unfortunately, this test and the one at the bottom of the file require either access to DOM or at least a DOM mocking library like happy-dom or jsdom.
Consider using Vitest's Browser Mode, which without isolation is still really fast.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #839 +/- ##
==========================================
+ Coverage 99.74% 99.78% +0.03%
==========================================
Files 309 310 +1
Lines 2787 2789 +2
Branches 829 830 +1
==========================================
+ Hits 2780 2783 +3
+ Misses 7 6 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.