-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't support dark
prefix
#27
Comments
@Svish I've actually added support for this (along with nested group support e.g. I'm not sure I want to make another issue so I might just add some context here if that's fine 😊 @acidic9 Thank you for this amazing library, but I noticed a few things, such as what I mentioned above, were unsupported, so I decided it would be "fun" to try and make my own... (I'm not making a formatter ever again 😩). I used your plugin as a base but rewrote the tailwind class sorter from scratch to support these features. Because of this, I felt opening a PR would be inconvenient since the approach was quite different (I opted for recursive sorting to sort nested groups). All the logic for my variation of the sorter can be found here under Let me know if you have any questions. Thanks again for maintaining this plugin! |
@LonJonn Is it possible to make use of your fork instead of this one in a project until this is fixed? |
If you've made a fix, feel free to submit a PR and I'll merge. I'm just short of time for Open Source work at this time. |
I've published it to npm under prettier-plugin-tailsort for my own personal use, so you can use it from there if you'd like. However, I'm most likely not going to be maintaining it much since I don't have much free time, unfortunately.
I'm happy to, but the sorter I made doesn't support custom options for sort order, config location, etc. since I was mainly making this for myself. I'll most likely open a PR once I add support for these so that the features remain unchanged. |
@LonJonn If you fork and publish, please at least change the github links on npmjs.com. ;) |
Oh damn did I forget to? My bad I'll fix that now. |
The plugin doesn't seem to support/know about the
dark:
prefix used with dark mode.To Reproduce
Expected behavior
Sorting should've taken
dark:
into account. Either put them together at the end, or after it's "sibling":Versions:
The text was updated successfully, but these errors were encountered: