Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

グループの一括追加・削除のテストを追加 #2570

Merged
merged 5 commits into from
Jan 27, 2025
Merged

グループの一括追加・削除のテストを追加 #2570

merged 5 commits into from
Jan 27, 2025

Conversation

Pugma
Copy link
Contributor

@Pugma Pugma commented Jan 23, 2025

close #2521

@Pugma Pugma requested a review from pikachu0310 January 23, 2025 18:23
@Pugma Pugma marked this pull request as ready for review January 23, 2025 18:23
@Pugma
Copy link
Contributor Author

Pugma commented Jan 23, 2025

#2484 の実装で、 delete が走っていないところがあったのでそれだけ追加しました

CodeCov がフロントエンド同様 token 不足で動いていないので、そこも直す必要がありそうです
こちらもよろしくお願いします

kaitoyama
kaitoyama approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@kaitoyama kaitoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

削除ができていなかったの気づいていませんでした。テストもいい感じです。助かります!

@Pugma Pugma merged commit 51940c0 into master Jan 27, 2025
6 checks passed
@Pugma Pugma deleted the test/processingMultipleGroupMembers branch January 27, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaitoyama kaitoyama kaitoyama approved these changes

@pikachu0310 pikachu0310 Awaiting requested review from pikachu0310

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

groupsのbulk処理のtest
2 participants
@Pugma @kaitoyama