Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify explicit version of the base image #16

Open
osvso opened this issue Sep 1, 2016 · 3 comments
Open

Specify explicit version of the base image #16

osvso opened this issue Sep 1, 2016 · 3 comments

Comments

@osvso
Copy link

osvso commented Sep 1, 2016

Currently the Dockerfile is based on latest ubuntu image
FROM ubuntu
and therefore may become unstable at some point in time.
Please consider changing to specific verified version of ubuntu ex. ubuntu:16.04.

@tracer0tong
Copy link
Owner

tracer0tong commented Sep 2, 2016

Accordingly documentation on Dockerhub for ubuntu:latest container:

The ubuntu:latest tag points to the "latest LTS", since that's the version recommended for general use.

I'm not sure that it's so unsafe, because usually I'm trying to test container before pushing to Dockerhub.
Do you have some other concerns?

@osvso
Copy link
Author

osvso commented Sep 2, 2016

Yes, my only concern is that the underlaying ubuntu changes in between versions and may require some additional repositories or libraries in order to get the emulator working. If someone will clone you repo and build the image locally he may find it not working, which shouldn't be the case if the image is pulled from docker repo and tested, as you mentioned, up-front.

@tracer0tong
Copy link
Owner

@nightscape what do you think about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants