Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark entire folder as reviewed #30

Open
alissonbezerra opened this issue Apr 26, 2024 · 5 comments
Open

Mark entire folder as reviewed #30

alissonbezerra opened this issue Apr 26, 2024 · 5 comments
Labels
enhancement ✨ New feature or request UX

Comments

@alissonbezerra
Copy link

Hello, I guess it would be good if we have a command to mark all files inside a folder as reviewed.

Thanks

@fcasal fcasal added the UX label Apr 26, 2024
@fcasal fcasal added the enhancement ✨ New feature or request label May 16, 2024
@alxshine
Copy link

I'd be interested in this feature as well, and would be willing to take a crack at it. (We use your tool extensively at rootsys.at and are super happy BTW 🥳 )

I think the easiest way to get there is:

  • split toggleAudited into getting the URI from editor and
  • a toggleFileAudited(uri) function
  • add recursion or a loop in case URI is a directory
  • add bindings to that to the context menu

The same tactic would apply to ignored files (#32, #54) as well.

@fcasal
Copy link
Collaborator

fcasal commented Sep 20, 2024

Hi all,
I started working on this feature in this branch a few months ago https://github.com/trailofbits/vscode-weaudit/tree/review-folder, perhaps you can use it as starting point

@alxshine
Copy link

Oh nice, thx, the code is pretty much already there 🙌

@TheZ3ro
Copy link

TheZ3ro commented Sep 20, 2024

dammit, I've implemented the same feature just now 😅 https://github.com/TheZ3ro/vscode-weaudit/tree/main

@rootsys-alxshine
Copy link

Lol nice :D
I mean if you want, go submit the PR, your code looks solid 🚀

Potentially a configurable way of dealing with children would be cool

  • mark only directory
  • mark directory and direct children
  • fully traverse and mark all

I might take a whack at my own implementation, just for fun. Don't want to steal your thunder @TheZ3ro 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request UX
Projects
None yet
Development

No branches or pull requests

5 participants