Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

growing spaces on --show ouput #24

Closed
geftactics opened this issue Nov 5, 2019 · 4 comments
Closed

growing spaces on --show ouput #24

geftactics opened this issue Nov 5, 2019 · 4 comments

Comments

@geftactics
Copy link

Working great for me now! Thanks for all your work guys :)

Not sure if this is new to PR #23 or has always been there, but I seem to get moe extra spaces with each row returned by --show - By the end of the output I see several empty lines! Here is the beginning of the issue... Not a critical one for me, but might be a problem for others!

 dovico --show --current-week |more
== List of Time Entries between 2019-11-04 and 2019-11-08 ==
2019-11-04 [××××××××××××××××] [approved    ] 8.00h Operational *End User Computing
2019-11-04 [                ××××××××××××××××] [approved    ] 8.00h Leave & Absence "Sick leave
2019-11-04 [                                ××××××××××××××××] [approved    ] 8.00h Operational *Service Desk & Incident Management
2019-11-04 [                                                ××××××××××××××××] [approved    ] 8.00h Operational *Service Desk & Incident Management
2019-11-04 [                                                                ××××××××××××××××] [approved    ] 8.00h Operational *Service Desk & Incident Management
2019-11-04 [                                                                                ××××××××××××××××] [approved    ] 8.00h Leave & Absence "Maternity leave/Paternity leave
@chtitux
Copy link
Contributor

chtitux commented Nov 5, 2019

It has been introduced in #23 , so indeed, it's new!

The whitespace is added because your 6 time entries of 8 hours each are assigned on the same day.

Have you worked for 6 × 8h = 48 hours on 2019-11-04?

I see three possibilities there:

  • You've set all the assignments on the same day. It's a bug on your side :-)
  • You've set assignments on different days, but this gem sees all of them on a single day. It's a bug in the gem
  • You have access to assignments from everyone from your team/you + people other than you. It never happens to me (because I can't see my colleagues'assignments), but could cause that kind of issue. I'll try to restrict assignments to "myself"

If you're not sure, you can copy/paste what you see on Dovico website, it may help too!

@geftactics
Copy link
Author

The above was a small snip of the rows returned... I actually get 700 rows, although I don't think I can see others time in the UI.

Screengrab of my time for current week is attached. I guess restricting to $myself might be the good fix here?

Untitled

@chtitux
Copy link
Contributor

chtitux commented Nov 6, 2019

Thanks for the detailed report.

I have updated the PR so it now fetches only your own records.

Could you test it & tell me if it's working as expected please?
Thanks!

@geftactics
Copy link
Author

Perfect!! :)

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants