Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

real life ci example #28

Open
djalmaaraujo opened this issue Oct 25, 2021 · 2 comments
Open

real life ci example #28

djalmaaraujo opened this issue Oct 25, 2021 · 2 comments

Comments

@djalmaaraujo
Copy link

Hello! Thanks for this great tool. I just got here by reading the excellent article on medium. I am considering setting up this project into our ci integration, but I could not figure out how to get a previous stats.json from a previous build to compare with the current stats.json? Do you have a real-world example with Github actions, for instance?

I can think of many possibilities, but I wonder if you already have a GitHub workflow ready to go?

Thank you.

@davidhouweling
Copy link
Contributor

Hi, sorry for the big delay on response. I'll have to get back to you on it as I'm on holiday at present and only thought to look at the repo now.

Off the top of my head it's more that you would need a way to pull the build artifact in yourself into the PR branch and then compare it. I would have to do some investigating to see how to best write a GitHub action that would take care of this for you as it isn't present functionality.

@davidhouweling
Copy link
Contributor

hi, sorry i haven't gotten back sooner. the reason i didn't originally build a github action for this is because it would require a fair amount of setup and present actions like the upload-artifact action don't support working across branches. in essence you'd need to work out how to store the stats and fetch it back again. in a corporate/enterprise environment where you have your own way of storing artifacts, it becomes a lot easier, but there is still a bunch of know how per individual project setup (such as where does the output of the stats end up to then upload it to somewhere).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants