Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opens Tab on javascript Link #2

Open
Leimking opened this issue Aug 27, 2019 · 4 comments
Open

Opens Tab on javascript Link #2

Leimking opened this issue Aug 27, 2019 · 4 comments

Comments

@Leimking
Copy link

Leimking commented Aug 27, 2019

Hey.
I use your cool extension in the Vivaldi browser (chromium). With the last version it opens a new tab if its a javascript link (a href="javascript:...") instead of simply executing. If I disable "New Domain in New Tab" everything works as expected.

Please take a look if you handle this case. Thank you.

@ferdw
Copy link

ferdw commented Mar 20, 2021

same in Chrome

bluelovers added a commit to bluelovers/new-domain-in-new-tab that referenced this issue Jan 31, 2022
@paul-van-cotthem
Copy link

The issue of opening JavaScript links into a new tab was not fixed yet, it seems?

@paul-van-cotthem
Copy link

paul-van-cotthem commented Jun 24, 2022

@trambopoline @bluelovers

I modified the manifest.json file to meet Manifest V3 requirements. (Extensions developed for Manifest V2 will stop working in January 2023 and can no longer be updated either).

Here is the contents of that updated manifest file:

{
"manifest_version": 3,

"name": "New Domain in New Tab - Manifest V3",
"description": "Open links to new domains in a new tab. Configurable.",
"version": "1.0.2",
"options_page": "options.html",

"permissions":
[
"tabs",
"storage",
"contextMenus"
],

"host_permissions": [
"http:///",
"https:///"
],

"background": {
"service_worker": "background.js"
},

"icons":
{
"16": "icons/icon16.png",
"19": "icons/icon19.png",
"32": "icons/icon32.png",
"38": "icons/icon38.png",
"48": "icons/icon48.png",
"64": "icons/icon64.png",
"128": "icons/icon128.png"
},

"action": {}
}

@paul-van-cotthem
Copy link

paul-van-cotthem commented Jun 25, 2022

Alas, my update of the "manifest.json" file to Manifest V3 standards is not sufficient to make the extension work under Manifest V3. The Extension manager in the browser shows multiple errors in the extension code (likely the JavaScript must be modified to meet certain Manifest V3 code requirements). Unfortunately, I do not have enough JavaScript expertise yet to fix these errors, so perhaps original extension developer @trambopoline or fork developer @bluelovers could have a look at how to get this extension to continue to work under Manifest V3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants