Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy approvals from previous release #684

Open
kitallis opened this issue Nov 22, 2024 · 2 comments
Open

Copy approvals from previous release #684

kitallis opened this issue Nov 22, 2024 · 2 comments
Labels
gitstart tickets for GitStart to pick up improvement Improve an existing feature

Comments

@kitallis
Copy link
Member

kitallis commented Nov 22, 2024

Context

We recently added a feature #662 to assign approvals to a release. These approvals block the submissions/rollouts for a release until they are completed / overriden.

Screenshot 2024-11-22 at 2 56 51 PM

We would like to enhance this feature to have Tramline copy approvals from the previous release so that users don't have to remember to assign and type them out again every release.

Requirements

This involves two things:

First, add a configuration (enable/disable toggle) in the train/release settings page, under the approvals section:
Screenshot 2024-11-22 at 2 58 58 PM

  • This would be a enable/disable toggle "Always copy approvals from previous release".
  • This setting will automatically copy over the approvals from the previous release in the next release when it starts.
  • With this setting, the approvals should not be copied over when it's a hotfix release.
  • This setting should be off by default.
  • This setting will show up only when the approvals checkbox is enabled.

Second, we should also allow copying approvals from within the release through a (currently disabled) button on the Approvals page This button should only show up and work when there are no approvals in the release, to avoid double-copying approvals.

Screenshot 2024-11-22 at 3 07 04 PM

Acceptance Criteria

  • Use the SwitchComponent to implement the enable/disable toggle.
  • Use the child switch functionality in the SwitchComponent.
  • When approvals are automatically copied over via the setting, the copy should happen in a background job.
  • Copying over approvals should send email as normal to assignees.
  • When there's nothing to copy, it should do nothing (for example, no previous release or no approvals from before).

Additional notes

Currently, the + Add button is disabled for certain states of the release – stuff after the submission has started. This check should exist for the copy button as well.

@kitallis kitallis added improvement Improve an existing feature gitstart tickets for GitStart to pick up and removed gitstart tickets for GitStart to pick up labels Nov 22, 2024
Copy link

Issue synced into GitStart. Please review, edit and hand it off to GitStart by following this link.

Copy link

This issue has been handed off to GitStart: https://clients.gitstart.com/tramline/11653/tickets/TRAB-684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gitstart tickets for GitStart to pick up improvement Improve an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant