Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the job jitter/delay around sidekiq retries #687

Open
kitallis opened this issue Nov 26, 2024 · 2 comments
Open

Fix the job jitter/delay around sidekiq retries #687

kitallis opened this issue Nov 26, 2024 · 2 comments
Labels
gitstart tickets for GitStart to pick up

Comments

@kitallis
Copy link
Member

kitallis commented Nov 26, 2024

Context

This is a pure technical debt requirement.

When retrying jobs via sidekiq_retry_in for example here. We compute a backoff value and then let sidekiq handle the retry. This generally works ok and keeps the code clean. But this is problematic for very large backoff values, which we often have, because the in-built jitter causes them to get very, very delayed.

Requirements & acceptance criteria

Move all Sidekiq job sidekiq_retry_in + sidekiq_retries_exhausted to actually normally rescue exceptions using rescue inside perform, and reenque the job via the backoff value, for example, here.

This will remove the in-built jitter and will ensure a bit more predictable delay in job enqueuing.

It will be interesting, to write a helper / concern or something that allow one to write the retry-reenqueue code easily without having to repeat too much in all jobs. Not sure if possible, worth exploring.

Additional Notes

This problem usually manifests as customer feedback where submission states are updated way too slowly, even though they have changed in App Store / Play Store.

@kitallis kitallis added the gitstart tickets for GitStart to pick up label Nov 26, 2024
Copy link

Issue synced into GitStart. Please review, edit and hand it off to GitStart by following this link.

Copy link

This issue has been handed off to GitStart: https://clients.gitstart.com/tramline/11653/tickets/TRAB-687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gitstart tickets for GitStart to pick up
Projects
None yet
Development

No branches or pull requests

1 participant