Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed] pickup crash #2145

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Gingerbeard5773
Copy link
Contributor

@Gingerbeard5773 Gingerbeard5773 commented Oct 24, 2024

Status

  • READY

Description

  • Fixes a client side crash that can occur when players use the pickup-menu.
    It also fixes "random" crashes that people have.

  • Fixes an issue where players could throw blobs that weren't attached to their player.

Cause of the crash:
Line 13 StandardPickup.as

CBlob@[] blobs;
this.set("pickup blobs", blobs);
CBlob@[] closestblobs;
this.set("closest blobs", closestblobs);

This PR also changes how pickup deals with platforms.
Players cannot pickup through platforms that are facing against them, but can pickup through platforms if they are facing with them. (this addition to this PR means that #1864 and #1342 can be closed)

resolves #1864, resolves #1342, resolves #2087

@Vam-Jam Vam-Jam self-assigned this Oct 24, 2024
@Vam-Jam Vam-Jam added the fix Fixes a bug label Oct 24, 2024
@Vam-Jam Vam-Jam added this to the Next Patch milestone Oct 25, 2024
@Gingerbeard5773
Copy link
Contributor Author

After testing the changes on XDoodles Zombies server, I can confidently say that this PR will fix the 'random' crashes that occur on staging.

mehwaffle10 added a commit to mehwaffle10/Waffle_Balance that referenced this pull request Nov 20, 2024
Added Gingerbeard's pick menu crash fix (transhumandesign/kag-base#2145)
@Vam-Jam Vam-Jam added the ready A pull request that functions correctly and is ready for testing label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug ready A pull request that functions correctly and is ready for testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Items getting repeatedly picked up and thrown across the map Items shouldn't be picked through platforms
2 participants