[changed] Boat movement speed changes

[mugg91]

Status

• READY: this PR is (to the best of your knowledge) ready to be incorporated into the game.

Description

This PR adjusts movement speed of Dinghy, Longboat and Warboat, and makes it so Dinghy doesn't create rear splashes from just one person riding it.

Fixes #2093

The threshold for this.getShape().vellen in BoatCommon.as was changed from 2.0 to 2.2.

Warboat's movement speed was buffed slightly and Dinghy's was nerfed slightly.
I don't think these changes will be really noticeable. Buffing Warboat should be a good thing either way.
These changes along with the threshold change makes it so that it requires 2 people riding Dinghy in order to create rear splashes (as was the case before the water speed change in 2021 while it still takes 4 people in a Warboat (as before) to create rear splashes.

I nerfed Longboat's movement speed slightly while I was at it, since it looks insanely fast when driven by 5 people. It still is ridiculously fast. Anyway, I think it looks better now.

This is just my one attempt at fixing problems, feel free to make suggestions. I think other than movement speed, boats

• need health buffs
• should not reward enemies so many coins when breaking them
• should give rowers protection from attacks from below
• need other kinds of promotion

Reproduction

In VehicleCommon.as, in void Vehicle_RowerControls(CBlob@ this, CBlob@ blob, AttachmentPoint@ ap, VehicleInfo@ v)
I added multiple instances of the if (right) and if (left) codeblocks to simulate multiple people riding into one direction.

[Vam-Jam]

This seems to be buggy in dedicated server. Dinghy for example rotates a lot, other boats seems to move enough that it looks jittery.

[mugg91]

Could you make a video of it? I have not encountered such problems.

If problems from speed changes cannot be fixed, it's still possible to keep the current speeds and handle rear splashes depending on the boat used.

Still want to emphasize that Longboat with 5 rowers looks stupidly fast. That's what I wanted to address mostly.

[Vam-Jam]

It seems like its a problem with vanilla, my comment can be ignored.

https://fs.vamist.dev/47c067-2024-11-23%2011-52-38.mp4

I'll mark as discussion for now as it changes boat speeds but I doubt anybody will have any issues with this as boats are basically unused at the moment

[mehwaffle10]

Boats and water combat in general need quite a face lift to make them enjoyable. I have a bunch of changes I've had in my balance mod for a while that may be worth discussing, but they lean far more into overhaul/rework territory than tweaks that can be cherry picked.

[Vam-Jam]

I'd be open for a overhaul/rework of boats, and I'd imagine most people would agree. Open up an issue if this is something you'd be open to discussing and potentially take on.