[fixed] Don't damage items held by teammates #2172
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Description
Fixes #2170
Might fix some symptoms described here #1267
This PR makes it so own damage sources (bomb explosion, drill, ballista bolt, catapult rocks) don't hurt own held items (log, fishy, chicken, enemy corpse, enemy crate, etc.).
I removed this code from
Rock.as
andBallistaBolt.as
:This code doesn't seem to serve any purpose. It basicly means, if blue player A holds red player B, then player A doesn't take damage from red catapult rocks. The only time a player can hold another player is when they are dead, but then they get untagged
"player"
so this code never even runs. Let me know if it does serve any purpose, though.Tested in offline, should work in online.
Reproduction
You can put a chicken in your catapult, then try to drill it or place a bomb or shoot with another catapult at it.
Prior to this PR, it takes damage, after this PR it doesn't.