[added] TDM shop can be destroyed #2177
Conversation
| // spawn trader that can be killed | ||
| if (this.exists("trader sex num")) | ||
| { | ||
| CBlob@ trader = server_CreateBlobNoInit("trader"); |
There was a problem hiding this comment.
You should be calling trader.Init() + doing a null check
Clients can run this code and end up hitting a null error.
|
I don't think this is a good change. I think it'd lead to more frustration than any interesting gameplay. The focus of TDM should be on fighting each other not on map destruction. Is there anything in particular this is meant to address? |
Just for fun, adding more aspects and things you can do to the game. |
|
like it |
- onHealthChange checks for isServer() now - when creating the trader blob, now checks if blob isn't null and runs Init()
Status
Description
Fixes #2027
This PR makes it so TradingPost of the other team can be destroyed (only in Sandbox and in TDM).
When destroyed, it spawns a trader of the same gender as the spritelayer that can be killed.
I made it so gender of the spritelayer depends on Network ID so it is the same for everyone and nobody will say
"I killed the trader woman"
"Weird, it's a male trader for me"
Also fixed a check in
onHealthChange(), fromif (oldHealth > 0.0f && this.getHealth() < 0.0f)toif (oldHealth > 0.0f && this.getHealth() <= 0.0f).Tested in offline and online, no problems found.
TradingPostDestructible.mp4
Remaining Issues
Some maps have blue trading post in the center, so only red team could damage it. Those maps would need to be changed to have a trading post that isn't team 0 or 1. Or we could allow hits to be processed regardless if it's the same team.
TDM shop might be destroyed too quickly, so health could be increased or attack's damage lowered.
Overall, I'm satisfied though.