Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[added] Indicator that shows how much gold is in your team's inventories #2182

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mugg91
Copy link
Contributor

@mugg91 mugg91 commented Nov 24, 2024

Status

  • READY: this PR is (to the best of your knowledge) ready to be incorporated into the game.

Description

[added] Indicator that shows how much gold is in friendly inventories

Fixes #2066

This PR adds a feature to indicate gold in your teammates' inventories as well as friendly Crates, Dinghies, Outposts, etc.

The blobs not showing gold are:

  • you
  • any blob that isn't from your team
  • storage (because it already indicates if it has gold)

This is so you quickly know where your team's gold is and people can't grief by hiding gold in their inventory.

The gold indicator will be shown to the right of the health bar. It looks like this:

For players, the indicator will shift to the right the more hearts they have.

I have tested it in offline mostly, only a little in online but it looks to be working the same.

@Vam-Jam
Copy link
Member

Vam-Jam commented Nov 24, 2024

You'll want to check that this pr works with this other PR that moves hearts script side, as it will be merged at some point.
#1761

@Vam-Jam Vam-Jam added the feature pitch A pitch for a new feature or mechanic label Nov 24, 2024
@mugg91
Copy link
Contributor Author

mugg91 commented Nov 24, 2024

I would like it if people discuss if this is something they want in the game, before I continue.
Have not looked at the code of the script-side player names PR yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature pitch A pitch for a new feature or mechanic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Teammate builders should indicate if they have gold in their inventory
2 participants