[fixed] You no longer can take fall damage twice on the same tick #2185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Description
Fixes #2183
When applying the fall damage hit in
FallDamage.as
, the game time is saved to the blob.At the beginning of
onCollision()
the code drops out if it detects that it's the same tick again so it doesn't apply the hit twice.I'm not sure why it happens in the first place. This is just a simple fix I came up with. Of course it could be worth looking for the root of the problem.
Tested in offline and online, works correctly.
Reproduction
Build a construction like in the screenshot from the issue linked above.
You have to be standing on a corner with the block being on your left or right side of the character.
When getting bounced down, you are taking two hits for 1 heart of total damage. After this PR, it is only one hit for a total of 0.5 hearts damage