Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 4 issue #30

Open
brasycad opened this issue Mar 28, 2017 · 4 comments
Open

Angular 4 issue #30

brasycad opened this issue Mar 28, 2017 · 4 comments

Comments

@brasycad
Copy link

No description provided.

@siovene
Copy link

siovene commented Mar 29, 2017

Ok, @brasycad didn't bother with a description, but I think he means that this library should be updated to support Angular 4. At the moment using it results in peer dependency warnings, even tho the library actually works. Perhaps a simple update to package.json?

@brasycad
Copy link
Author

brasycad commented Mar 29, 2017

Sorry for no description.
You need to fix a small compilation error with angular 4 for production:

ERROR in /Users/josemanuelvillaralarcon/GitHub/brasycad-imoveis/src/$$_gendir/node_modules/angular2-fontawesome/src/fa.component.ngfactory.ts (1,1): Property 'classList' is private and only accessible within class 'FaComponent'.
Thank you. I hope it help

@AdrianSima
Copy link

AdrianSima commented Mar 31, 2017

What @siovene says was my initial guess too and temporarily fixed it by adding || >=4.0.0 to the dev and peer dependencies in package.json like this:
`"devDependencies": {
"@angular/common": "^2.1.0 || >=4.0.0",
"@angular/compiler": "^2.1.0 || >=4.0.0",
"@angular/compiler-cli": "^2.1.0 || >=4.0.0",
"@angular/core": "^2.1.0 || >=4.0.0",

...
"peerDependencies": {
"@angular/common": "^2.0.0 || >=4.0.0",
"@angular/core": "^2.0.0 || >=4.0.0"
}`

I think the error @brasycad wishes to report is linked to #28

I apologize if I am making a mess here, but I don't really know what I am doing.

@brasycad
Copy link
Author

brasycad commented Apr 1, 2017

Hi, @AdrianaSima. I tried with new package.json, but still give same compilation error.
Any suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants