Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update golang version, go.mod requirements and dockerfile #163

Open
BOPOHA opened this issue Apr 25, 2020 · 0 comments
Open

update golang version, go.mod requirements and dockerfile #163

BOPOHA opened this issue Apr 25, 2020 · 0 comments

Comments

@BOPOHA
Copy link

BOPOHA commented Apr 25, 2020

hello @travisjeffery
i'd like to play with your project, but i think, after moving dep -> go modules it is unusable.
I can provide PR for features in subject, please confirm that the changes will be accepted,

and, one more question, do you know who or where using it in production ?

BOPOHA added a commit to BOPOHA/jocko that referenced this issue Apr 27, 2020
…ffery#163"

- removed dep-related comands and notes
- added two Dockerfiles (works with Podman, Buildah too)
  - "prod": for clean build, with tests, runnng with non-root user, from scratch container
  - "dev":  there is caching for golang deps, without tests, run as root, and result container can be not from scratch, for debug reasons.
- docker-compose file:
  - added shared context-build block, DRY.
  - removed command name `jocko` in line `command: jocko broker...` because of we using the same ENTRYPOINT in docker file.

- small fixes in module paths:
  - "github.com/hashicorp/consul/testutil/retry" -> "github.com/hashicorp/consul/sdk/testutil/retry"

- update go.mod to the lastest version for all transitive deps (exepts github.com/mitchellh/go-testing-interface v1.4.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant