Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log application shutdown #847

Closed
jemshad opened this issue Mar 16, 2021 · 8 comments
Closed

Log application shutdown #847

jemshad opened this issue Mar 16, 2021 · 8 comments
Assignees
Labels
_complexity:low A task with a low complexity that should be easy to understand enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed _size:small A small task that should be quick to do

Comments

@jemshad
Copy link

jemshad commented Mar 16, 2021

Describe the problem you are trying to solve

When the application is shutdown normally (using systemd in this case), some information about that in the logs would really help in troubleshooting to know what time the application stopped.

Describe the solution you'd like
Log lines saying application going for a shutdown

Notes
-NA-

If this is an implementation of an RFC provide a URL
to the RFC this enhancement implements.

If this is a major enhancement or contribution an RFC may be required. It is ok to submit an enhancement
first and our core team will assist with major contributions. In general, major contributions should be
discussed with the community before submission.

@jemshad jemshad added the enhancement New feature or request label Mar 16, 2021
@Licenser Licenser added _complexity:low A task with a low complexity that should be easy to understand _size:small A small task that should be quick to do good first issue Good for newcomers help wanted Extra attention is needed labels Mar 31, 2021
@Udbhavbisarya23
Copy link

Hi, if this issue is open, I'd like to take it up!

@mfelsche
Copy link
Member

Go for it! :) Shall I assign you, so we make it official?

@Udbhavbisarya23
Copy link

Sounds good, Thanks!

@mfelsche
Copy link
Member

Please be aware that all this is currently in a phase of being rewritten with #1077 So maybe you go look on that branch for making that change

@Udbhavbisarya23
Copy link

I've got the repository set up on my system, but I would like to replicate this behaviour locally. Could I please get more insight into this?

@mfelsche
Copy link
Member

We have a systemd service file: https://github.com/tremor-rs/tremor-runtime/blob/main/packaging/distribution/etc/systemd/system/tremor.service

You can use this to spawn tremor on your system and then stop it. Upon stop it should log something.

@Udbhavbisarya23
Copy link

I'll have a look into this. Thank you for the quick response!

@Licenser
Copy link
Member

we log sutdowns with the connector changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_complexity:low A task with a low complexity that should be easy to understand enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed _size:small A small task that should be quick to do
Projects
None yet
Development

No branches or pull requests

4 participants