Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for new version of simd-json and value trait #2357

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Conversation

Licenser
Copy link
Member

Pull request

Description

simd-json 0.13 update

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

-/-

Signed-off-by: Heinz N. Gies <[email protected]>
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #2357 (82b7cde) into main (81897ea) will increase coverage by 36.73%.
The diff coverage is 93.22%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2357       +/-   ##
===========================================
+ Coverage   54.06%   90.80%   +36.73%     
===========================================
  Files         271      281       +10     
  Lines       39624    59664    +20040     
===========================================
+ Hits        21424    54177    +32753     
+ Misses      18200     5487    -12713     
Flag Coverage Δ
unittests 90.80% <93.22%> (+36.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/connectors.rs 88.36% <ø> (+18.02%) ⬆️
src/connectors/google.rs 88.70% <ø> (+88.70%) ⬆️
src/connectors/impls/clickhouse/conversion.rs 96.57% <100.00%> (+68.54%) ⬆️
src/connectors/impls/crononome.rs 95.60% <ø> (ø)
src/connectors/impls/elastic.rs 94.29% <100.00%> (+18.82%) ⬆️
src/connectors/impls/exit.rs 97.40% <ø> (ø)
src/connectors/impls/gcl/writer/meta.rs 99.48% <ø> (+99.48%) ⬆️
src/connectors/impls/gpubsub/producer.rs 98.06% <ø> (+94.81%) ⬆️
src/connectors/impls/http/meta.rs 93.45% <ø> (+9.68%) ⬆️
src/connectors/impls/http/server.rs 84.89% <ø> (+11.91%) ⬆️
... and 41 more

... and 196 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81897ea...82b7cde. Read the comment docs.

Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@Licenser Licenser merged commit 2155413 into main Oct 26, 2023
18 checks passed
@Licenser Licenser deleted the simd-json-13 branch October 26, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants