Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multisite support #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

theMikeD
Copy link

@theMikeD theMikeD commented Apr 13, 2024

Add support for --url option, for proper use in multisite environments

@8ctopus
Copy link

8ctopus commented Aug 29, 2024

@theMikeD Awesome work!
@trepmal Do you plan on reviewing the PR? If not, README should state than multisite support is not planned.

@8ctopus 8ctopus mentioned this pull request Aug 29, 2024
@8ctopus
Copy link

8ctopus commented Aug 29, 2024

@theMikeD Maybe you could enable issues in your repository while waiting for the PR approval? This way other users can install your flavor of the package.

@trepmal
Copy link
Owner

trepmal commented Aug 29, 2024

Thanks for the ping @8ctopus , my personal email inbox is a bit untamed at the moment.

Multisite support should be there out of the box. A quick test correctly gave be different results for wp revisions list. Is there a specific situation where you're seeing incorrect behavior or getting an error?

trepmal production ~ $ wp revisions list --url=<redacted>
+----+------------------+-------------+
| ID | post_title       | post_parent |
+----+------------------+-------------+
| 46 | Roman-Middle     | 9           |
| 45 | Roman-Middle     | 9           |
| 44 | Roman-Middle     | 9           |
| 43 | Roman-Middle     | 9           |
| 42 | Roman-Middle     | 9           |
...
+----+------------------+-------------+

trepmal production ~ $ wp revisions list
Warning: --url was not specified
List all 4654 revisions? [y/n] 

@8ctopus
Copy link

8ctopus commented Aug 30, 2024

@trepmal Thank you for the quick reply, I did not test it as from the issue and from the PR multi-site doesn't work. Now that you answered, I will test and report back.

@8ctopus
Copy link

8ctopus commented Sep 2, 2024

@trepmal I have tested it today and can confirm that the list command shows different revisions when I update the url

wp revisions list --url=https://.../blog/

Update: I tested all commands locally on my multi-site development installation and can happily confirm that the vanilla version works without the need for this PR, but maybe @theMikeD found cases where it doesn't work since he submitted the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants