Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excel Parser hangs if SharedStrings.xml is missing from file being parsed. #50

Open
daric81 opened this issue Aug 9, 2017 · 2 comments

Comments

@daric81
Copy link

daric81 commented Aug 9, 2017

Got caught for a while on this issue. If SharedStrings.xml is mandatory then an error should be thrown.

@trevordixon
Copy link
Owner

You're right! Thanks for the report.

Out of curiosity, do you know about https://github.com/SheetJS/js-xlsx? If so, why use excel.js instead of that? I haven't touched this in a long time, and I wonder if I should just point people to that other option, or if there's something compelling about this that I should make clear or enhance.

Thanks again!

@daric81
Copy link
Author

daric81 commented Sep 4, 2017

I didn't actually. Don't know how I didn't come across that project when looking at what was out there. I'll definitely take a look when I'm back working on import/export in our app.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants