Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native Electrum server connection from Umbrel #5138

Closed
hynek-jina opened this issue Mar 17, 2022 · 6 comments
Closed

Native Electrum server connection from Umbrel #5138

hynek-jina opened this issue Mar 17, 2022 · 6 comments
Assignees
@marekrjpolak
Labels
code Code improvements low hanging fruit Simple, quick task. Doable in 2 hours.

Comments

@hynek-jina
Copy link
Contributor

Create a Pull request in the Umbrel repository that would allow direct connection of the Electrum server to the Trezor Suite natively from Umbrel.

https://github.com/getumbrel/umbrel-dashboard/tree/master/src/components/ConnectWallet/Wallets
@hynek-jina hynek-jina added code Code improvements low hanging fruit Simple, quick task. Doable in 2 hours. labels Mar 17, 2022
@hynek-jina hynek-jina added LOW and removed low hanging fruit Simple, quick task. Doable in 2 hours. labels Mar 28, 2022
@tsusanka tsusanka added HIGH low hanging fruit Simple, quick task. Doable in 2 hours. and removed LOW labels Apr 1, 2022
@tsusanka
Copy link
Contributor

tsusanka commented Apr 1, 2022

I am moving this to HIGH as it would be really nice to make it till the feature is somewhat new.

@hynek-jina hynek-jina added the design needed Development is blocked by lack of design label Apr 4, 2022
@hynek-jina hynek-jina self-assigned this Apr 4, 2022
@sime
Copy link
Member

sime commented Apr 5, 2022

@tsusanka I offered a PR upstream. Please leave any comments there. getumbrel/umbrel-dashboard#413

@tsusanka
Copy link
Contributor

tsusanka commented Apr 5, 2022

Haven't built it, but it seems great to me 👍. cc @marekrjpolak if he wants to check it.

@hynek-jina hynek-jina moved this to 🔎 Needs review in Issues Suite Apr 6, 2022
@hynek-jina hynek-jina assigned marekrjpolak and unassigned hynek-jina Apr 6, 2022
@marekrjpolak
Copy link
Contributor

I've fixed one unclosed span and added the new Trezor Suite page to the wallets list, and it looks good. Should I make a PR to the @sime's forked repo? Or will we do it differently?

image

@sime
Copy link
Member

sime commented Apr 7, 2022

@marekrjpolak Glad you built it, as I was struggling a little. I add you as a collaborator to my fork. I suggest you push there so it's ready to go in the one PR.

@hynek-jina hynek-jina removed the design needed Development is blocked by lack of design label Apr 14, 2022
@hynek-jina
Copy link
Contributor Author

Everything done from our side. Now we are waiting for Umbrel to release a new version.

Repository owner moved this from 🔎 Needs review to 🤝 Needs QA in Issues Suite May 5, 2022
@hynek-jina hynek-jina moved this from 🤝 Needs QA to ✅ Approved in Issues Suite May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marekrjpolak marekrjpolak

Labels
code Code improvements low hanging fruit Simple, quick task. Doable in 2 hours.
Projects
Issues Suite
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sime @tsusanka @hynek-jina @marekrjpolak