Skip to content
This repository has been archived by the owner on Aug 13, 2022. It is now read-only.

Support Decred #8

Open
vctt94 opened this issue Apr 16, 2020 · 7 comments · May be fixed by #9
Open

Support Decred #8

vctt94 opened this issue Apr 16, 2020 · 7 comments · May be fixed by #9

Comments

@vctt94
Copy link

vctt94 commented Apr 16, 2020

decred is supported by trezor-firmware, but it is not supported for trezor-connect right now.

We used trezor.js for our connection, but with that being deprecated, now we need to support decred at trezor-connect, so we can still supporting trezor.

@szymonlesisz
Copy link

Decred cannot be fully supported since its not compatible with bitcoinjs, or to be precise trezor fork of bitcoinjs lib.
signTransaction method is affected since it does validate output addresses and signed transaction using mentioned @trezor-utxo-lib

@vctt94
Copy link
Author

vctt94 commented Apr 17, 2020

Thanks for letting me know. So should I move this issue there?

@szymonlesisz
Copy link

yes, trezor-utxo-lib is the place to start, but since i'm also the maintainer of it i can tell you that right now i don't have a time to implement this. sorry :/

However any contribution is welcome i can put you thru the process, what needs to be done or changed

@szymonlesisz szymonlesisz transferred this issue from trezor/connect Apr 18, 2020
@szymonlesisz
Copy link

szymonlesisz commented Apr 18, 2020

briefly:
Address validation fromBase58Check needs to be be hashed (twice?) using blake

There is already blake2b dependency in this project and could be used to do that here

Also probably Transaction.fromBuffer and Transaction.toBuffer will also require some some modifications (i didn't test it)

@vctt94
Copy link
Author

vctt94 commented Apr 20, 2020

Thanks for the start.

Yeah, our checksum is hashed twice: https://github.com/decred/base58/blob/master/base58check.go#L23

I'll look into the code and any questions I have I ask here. Thanks for your time.

@JoeGruffins JoeGruffins linked a pull request Apr 28, 2020 that will close this issue
@vctt94
Copy link
Author

vctt94 commented May 19, 2020

Hey @szymonlesisz , when possible, plz review #9

@prusnak prusnak linked a pull request May 19, 2020 that will close this issue
@JoeGruffins
Copy link

@szymonlesisz @prusnak
Should I continue working on this? We are rolling our own for the time being, but would sure like to get decred into master. I will wait for comment before pushing any more changes here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants