Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise default for jdbc domain-compaction-threshold #23381

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Raise default for jdbc domain-compaction-threshold #23381

merged 1 commit into from
Sep 12, 2024

Conversation

raunaqmorarka
Copy link
Member

@raunaqmorarka raunaqmorarka commented Sep 12, 2024 •
edited
Loading

Description

Reduces data transfer out of remote systems.
Most systems can handle IN lists of a few hundered values.

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# JDBC
* Reduce data transfer from remote systems for queries with large IN lists. ({issue}`23381`)

@raunaqmorarka
Raise default for jdbc domain-compaction-threshold
db5b6f6 
Reduces data transfer out of remote systems.
Most systems can handle IN lists of a few hundered values.
@cla-bot cla-bot bot added the cla-signed label Sep 12, 2024
@github-actions github-actions bot added the docs label Sep 12, 2024
hashhar
hashhar reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the direction - need to check for impact.

There is a test called testLargeIn IIRC which we can use to check the values are "safe".

@raunaqmorarka raunaqmorarka merged commit e036fcc into master Sep 12, 2024
73 of 74 checks passed
@raunaqmorarka raunaqmorarka deleted the bump-domain-threshold branch September 12, 2024 13:02
@github-actions github-actions bot added this to the 458 milestone Sep 12, 2024
@mosabua mosabua mentioned this pull request Sep 14, 2024
Merged
@mosabua
Copy link
Member

mosabua commented Sep 14, 2024

I have a feeling this affects more connectors. For example Snowflake?

@raunaqmorarka
Copy link
Member Author

It affects all jdbc based connectors

@mosabua mosabua mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar approved these changes

@nineinchnick nineinchnick nineinchnick approved these changes

@wendigo wendigo wendigo approved these changes

@mayankvadariya mayankvadariya Awaiting requested review from mayankvadariya

@findinpath findinpath Awaiting requested review from findinpath

Assignees
No one assigned
Labels
cla-signed docs
Milestone
458
Development

Successfully merging this pull request may close these issues.
5 participants
@raunaqmorarka @mosabua @wendigo @nineinchnick @hashhar