Sql types SPI cleanup #24228
Open
Sql types SPI cleanup #24228
+115
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/spi-cleanup
branch
from
6d45b66
to
3f2cb77
Compare
losipiuk
reviewed
Nov 22, 2024
| case SqlVarbinary varbinary -> generator.writeFieldName(Base64.getEncoder().encodeToString(varbinary.getBytes())); | ||
| case Object value -> generator.writeFieldName(value.toString()); | ||
| } | ||
| generator.writeFieldName(mapType.getKeyType().getObjectValue(session, keyBlock, offset + i).toString()); |
There was a problem hiding this comment.
Comment above mentions backward compatibility. But we are changing how it works just know. Is that commment even important at all?
There was a problem hiding this comment.
It is, JSON v1 format always serializes key to a String, even if it is a map or list.
|
@martint any context why it was done like it was? Was that important for some reason? |
wendigo
force-pushed
the
serafin/spi-cleanup
branch
2 times, most recently
from
2b75fea
to
aa17702
Compare
Other Sql* classes are serialized to JSON on-the-wire format, using @JsonValue annotated toString methods, except for SqlVarbinary which was serialized using its' getBytes() method that was Base64-encoded to a map key.
wendigo
force-pushed
the
serafin/spi-cleanup
branch
2 times, most recently
from
77511b5
to
e52c451
Compare
The new JSON serialization is not using ObjectMapper to serialize these values anymore. We want to decouple SPI types from JSON representation to be able to introduce alternative encoding formats.
wendigo
force-pushed
the
serafin/spi-cleanup
branch
from
e52c451
to
e4ba2d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: