Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refresh-period configuration documentation #24183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daha
Copy link
Contributor

@daha daha commented Nov 19, 2024

Fix the refresh-period configuration for
case-insensitive-name-matching.config-file.

Description

There are errors in the existing documentation for Case insensitive matching. The field
case-insensitive-name-mapping.refresh-period is not valid, it should be case-insensitive-name-matching.config-file.refresh-period.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

Fix the refresh-period configuration for
`case-insensitive-name-matching.config-file`.
Copy link

cla-bot bot commented Nov 19, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the docs label Nov 19, 2024
@mosabua
Copy link
Member

mosabua commented Nov 19, 2024

Thanks for catching this. Did you submit a signed CLA already?

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We just got to wait for the CLA.

@daha
Copy link
Contributor Author

daha commented Nov 20, 2024

Thanks for catching this. Did you submit a signed CLA already?

I signed and emailed the CLA yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants