[DRAFT][FRONTEND] added support for tuples #5220
Draft
+518
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptillet
commented
Nov 21, 2024
| assert y[1] == 10 | ||
| assert y[2] == vals[1] | ||
|
|
||
| # ------- |
There was a problem hiding this comment.
TODO: add more unit tests
ptillet
commented
Nov 21, 2024
| from abc import ABCMeta, abstractmethod | ||
| from dataclasses import dataclass | ||
| from typing import Dict, List, Tuple, Union | ||
| from types import ModuleType | ||
|
|
||
| def find_paths_if(iterable, pred): |
There was a problem hiding this comment.
TODO: remove duplicate
ptillet
commented
Nov 21, 2024
| @@ -57,8 +60,7 @@ def _is_triton_tensor(o: Any) -> bool: | |||
|
|
|||
|
|
|||
| def _is_constexpr(o: Any) -> bool: | |||
| return isinstance(o, constexpr) | |||
|
|
|||
| return o is None or isinstance(o, (constexpr, language.core.dtype, int, bool)) | |||
There was a problem hiding this comment.
TODO: condition should be more generic
ptillet
commented
Nov 21, 2024
| @@ -1304,30 +1299,92 @@ def kernel_suffix(signature, specialization): | |||
| return suffix | |||
|
|
|||
|
|
|||
| def find_paths_if(iterable, pred): | |||
There was a problem hiding this comment.
TODO: remove duplication
ptillet
commented
Nov 21, 2024
| return ret | ||
|
|
||
|
|
||
| class ASTFunction: |
There was a problem hiding this comment.
TODO: is it the right place?
ptillet
commented
Nov 21, 2024
| @@ -261,6 +264,31 @@ | |||
| ] | |||
|
|
|||
|
|
|||
| def parse_list_string(s): | |||
There was a problem hiding this comment.
TODO: is it the right place ?
ptillet
commented
Nov 21, 2024
| @@ -38,6 +38,14 @@ def wrapper(*args, **kwargs): | |||
| return wrapper | |||
|
|
|||
|
|
|||
| def _flatten_list(lst): | |||
There was a problem hiding this comment.
TODO: is it the right place ?
ptillet
commented
Nov 21, 2024
| @@ -17,6 +17,29 @@ | |||
| libraries = ['cuda'] | |||
|
|
|||
|
|
|||
| def parse_list_string(s): | |||
There was a problem hiding this comment.
TODO: a lot of this file should be reused between different backends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cl