Add getindex for ConduitNode #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Implementing this was not straightforward as you have to use the method for the correct data type, which you first have to look up. I now create a symbol from the name of the C datatype and pass this to an internal method as another argument to be able to dispatch on it. |
Me too. Maybe you can ping Valentin and ask him if he knows of a better approach for what you are trying to achieve? Adding some context would be helpful as well. |
|
I think we may have something similar in ClimaCore (the DataLayouts module) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
getindexfor ConduitNode.Although not required for using the interface it makes testing easier.