Allow periodicity for very basic meshes #16
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
===========================================
- Coverage 100.00% 99.44% -0.56%
===========================================
Files 2 2
Lines 55 180 +125
===========================================
+ Hits 55 179 +124
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. |
| @testset "non-periodic" begin | ||
| neighbors = delaunay_compute_neighbors(data_points, vertices) | ||
| @test neighbors == [6 4 2 0 6 1; | ||
| 4 3 5 1 0 0; | ||
| 0 0 0 2 3 5] | ||
| end | ||
| @testset "periodic" begin | ||
| neighbors = delaunay_compute_neighbors(data_points, vertices, periodicity = (true, false)) | ||
| @test neighbors == [6 4 2 3 6 1; | ||
| 4 3 5 1 1 0; | ||
| 5 0 4 2 3 5] | ||
| neighbors = delaunay_compute_neighbors(data_points, vertices, periodicity = (false, true)) | ||
| @test neighbors == [6 4 2 0 6 1; | ||
| 4 3 5 1 0 2; | ||
| 0 6 0 2 3 5] | ||
| neighbors = delaunay_compute_neighbors(data_points, vertices, periodicity = (true, true)) | ||
| @test neighbors == [6 4 2 3 6 1; | ||
| 4 3 5 1 1 2; | ||
| 5 6 4 2 3 5] | ||
| end |
There was a problem hiding this comment.
To cover mostly everything in the test, the unit tests became a bit longer. But I don't have an idea to shorten this.
|
@sloede Do you have any idea why the tests don't appear to have started, but have actually already run, as you can see if you look at the Checks tab or press on the red X on the last commit? |
No, but I've seen this weird behavior before in other PRs in the trixi framework org. Dunno what's causing this... |
Okay, thanks anyway. |
No description provided.