Apply @muladd more specifically?

[ranocha]

I'm just annoyed again by Revise not playing nicely with @muladd when struct definitions are included. What do you think about applying @muladd more specifically to function definitions where it makes sense?

[sloede]

Is there really no other way to enable muladd globally? Are you able to estimate how many functions would be affected?

[ranocha]

Alternatively, we could try to move all type definition out of the @muladd blocks.

[sloede]

Alternatively, we could try to move all type definition out of the @muladd blocks.

I feel like this is even worse. That would force us to rearrange code in files only for performance considerations. I think in this case I'd rather have @muladd added to individual functions, although we should make clear whether it goes before or after @inline

[ranocha]

Is there really no other way to enable muladd globally?

I don't see another way right now...

Are you able to estimate how many functions would be affected?

Probably everything that does non-trivial computations - quite a lot, I guess?

[jlchan]

Would delaying adding muladd for files with experimental features make sense? Revise and muladd have been annoying for me too, but removing the muladd blocks during development has largely fixed that.

[ranocha]

That would help when adding new files but

• we would need to remember adding it in time
• it doesn't help with already existing files, e.g., for allow other RHS in analysis callback #1205